New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against empty inputs for objs expressions. #11311
Conversation
Changelog[uncommitted] (2022-11-14)Bug Fixes
|
These test failures look legit. :( |
I'm going to come back to this tomorrow. Putting this down for now to clear my head a bit 👍🏻 |
@RobbieMcKinstry this failure:
is because the unit test I wrote before used an empty object as input for the function which is what the new code guards against 😅 the check |
bors r+ |
11311: Guard against empty inputs for objs expressions. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description `@dirien` raised an issue where tfgen would panic converting PCL under an edge case where an `ObjectExpression` had `nil` arguments. By introducing this guard, we skip annotating the the Object with the type provided by the schema the function in the schema has no args. S/o to `@Zaid-Ajaj` for explaining this code to me and confirming the kill. I was lost without his aid! <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11305 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
Build failed: |
bors retry |
11311: Guard against empty inputs for objs expressions. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description `@dirien` raised an issue where tfgen would panic converting PCL under an edge case where an `ObjectExpression` had `nil` arguments. By introducing this guard, we skip annotating the the Object with the type provided by the schema the function in the schema has no args. S/o to `@Zaid-Ajaj` for explaining this code to me and confirming the kill. I was lost without his aid! <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11305 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
Build failed: |
bors retry |
Three instances of network connection, 500 error from NPM. |
Build succeeded: |
Description
@dirien raised an issue where tfgen would panic converting PCL under an edge case where an
ObjectExpression
hadnil
arguments. By introducing this guard, we skip annotating the the Object with the type provided by the schema the function in the schema has no args.S/o to @Zaid-Ajaj for explaining this code to me and confirming the kill. I was lost without his aid!
Fixes #11305
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my change